From bb7274526cfefdc5df306a222cd9dc84702e3b57 Mon Sep 17 00:00:00 2001 From: Alejandro Hernandez Date: Tue, 30 Jan 2024 13:54:30 -0500 Subject: [PATCH] Do not set empty highlights on hit if there are none --- .changeset/eleven-bikes-pull.md | 5 +++++ .../src/example-types/results/highlighting/search.js | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/eleven-bikes-pull.md diff --git a/.changeset/eleven-bikes-pull.md b/.changeset/eleven-bikes-pull.md new file mode 100644 index 000000000..2cc31ef3f --- /dev/null +++ b/.changeset/eleven-bikes-pull.md @@ -0,0 +1,5 @@ +--- +'contexture-elasticsearch': patch +--- + +Do not set empty highlights on hit if there are none. diff --git a/packages/provider-elasticsearch/src/example-types/results/highlighting/search.js b/packages/provider-elasticsearch/src/example-types/results/highlighting/search.js index febea113b..fc559b6a7 100644 --- a/packages/provider-elasticsearch/src/example-types/results/highlighting/search.js +++ b/packages/provider-elasticsearch/src/example-types/results/highlighting/search.js @@ -49,7 +49,9 @@ export let searchWithHighlights = (node, search, schema) => async (body) => { ) for (let hit of response.hits.hits) { - hit.highlight = getResponseHighlight(schema, hit, tags, nestedPathsMap) + if (hit.highlight) { + hit.highlight = getResponseHighlight(schema, hit, tags, nestedPathsMap) + } removePathsFromSource(schema, hit, addedPaths) mergeHighlightsOnSource(schema, hit) }