Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMolecule now respects the charge parameter z #31

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

janlisec
Copy link
Contributor

This will fix Issues #4 and #7. It potentially breaks old workflows because people might have implemented some post processing on Rdisop results to fix the issue.

From the changeLog:
* exact masses will be corrected by z times the electron mass
* isotope masses will be additionally devided in case of abs(z)>=2
* a testthat function for getMolecule was set up
* the documentation for getMolecule was updated
* previous users will be informed by a message when calling getMolecule with z!=0

@sneumann
Copy link
Owner

Hi, if this is a breaking change, what about bumping the version to 1.99 ?
Yours, Steffen

@janlisec
Copy link
Contributor Author

Your decision. :) It depends on how you see it. I believe as the parameter was doing nothing (except setting the charge slot), people did not bother to specify it in workflows. So, while it is leading to different results than before, the chance that it really breaks something is very low. It is rather a fix for #4 and #7.

@sneumann
Copy link
Owner

Convinced :-)

@sneumann sneumann merged commit ee41d3c into sneumann:devel Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants