From 942835496c42e7488954929bf1006e1563dbfab5 Mon Sep 17 00:00:00 2001 From: Frederick Roy Date: Thu, 26 Dec 2024 07:43:41 +0900 Subject: [PATCH] Apply suggestions from code review (update descriptions) Co-authored-by: Hugo --- .../plugins/MultiThreading/src/MultiThreading/DataExchange.cpp | 2 +- .../component/animationloop/AnimationLoopParallelScheduler.cpp | 2 +- .../collision/detection/algorithm/ParallelBVHNarrowPhase.cpp | 2 +- .../detection/algorithm/ParallelBruteForceBroadPhase.cpp | 2 +- .../component/linearsolver/iterative/ParallelCGLinearSolver.cpp | 2 +- .../fem/elastic/ParallelHexahedronFEMForceField.cpp | 2 +- .../fem/elastic/ParallelTetrahedronFEMForceField.cpp | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/applications/plugins/MultiThreading/src/MultiThreading/DataExchange.cpp b/applications/plugins/MultiThreading/src/MultiThreading/DataExchange.cpp index d5f05e6cd48..dbe0d4f11cf 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/DataExchange.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/DataExchange.cpp @@ -35,7 +35,7 @@ SOFA_EVENT_CPP(DataExchangeEvent) void registerDataExchange(sofa::core::ObjectFactory* factory) { - factory->registerObjects(core::ObjectRegistrationData("DataExchange") + factory->registerObjects(core::ObjectRegistrationData("Component for data memory sharing in the context of multi-threading applications") .add< DataExchange< sofa::type::vector > >(true) .add< DataExchange< sofa::type::vector > >() .add< DataExchange< sofa::type::vector > >() diff --git a/applications/plugins/MultiThreading/src/MultiThreading/component/animationloop/AnimationLoopParallelScheduler.cpp b/applications/plugins/MultiThreading/src/MultiThreading/component/animationloop/AnimationLoopParallelScheduler.cpp index 81b43cacd4f..636f04472d5 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/component/animationloop/AnimationLoopParallelScheduler.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/component/animationloop/AnimationLoopParallelScheduler.cpp @@ -41,7 +41,7 @@ namespace multithreading::component::animationloop void registerAnimationLoopParallelScheduler(sofa::core::ObjectFactory* factory) { - factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel animation loop, using intel tbb library.") + factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel animation loop, using the Intel tbb library.") .add< AnimationLoopParallelScheduler >()); } diff --git a/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBVHNarrowPhase.cpp b/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBVHNarrowPhase.cpp index 4cc7c18d89f..db0659a8504 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBVHNarrowPhase.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBVHNarrowPhase.cpp @@ -38,7 +38,7 @@ const bool isParallelBVHNarrowPhaseImplementationRegistered = void registerParallelBVHNarrowPhase(sofa::core::ObjectFactory* factory) { - factory->registerObjects(sofa::core::ObjectRegistrationData("Narrow phase collision detection based on boundary volume hierarchy.") + factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel version of the narrow phase collision detection based on boundary volume hierarchy.") .add< ParallelBVHNarrowPhase >()); } diff --git a/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBruteForceBroadPhase.cpp b/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBruteForceBroadPhase.cpp index b355f3686e0..242d543a303 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBruteForceBroadPhase.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/component/collision/detection/algorithm/ParallelBruteForceBroadPhase.cpp @@ -36,7 +36,7 @@ const bool isParallelParallelBruteForceBroadPhaseImplementationRegistered = void registerParallelBruteForceBroadPhase(sofa::core::ObjectFactory* factory) { - factory->registerObjects(sofa::core::ObjectRegistrationData("Collision detection using extensive pair-wise tests performed in parallel.") + factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel version of the collision detection using extensive pair-wise tests performed concurrently.") .add< ParallelBruteForceBroadPhase >()); } diff --git a/applications/plugins/MultiThreading/src/MultiThreading/component/linearsolver/iterative/ParallelCGLinearSolver.cpp b/applications/plugins/MultiThreading/src/MultiThreading/component/linearsolver/iterative/ParallelCGLinearSolver.cpp index 89b9be10bde..5838bb7295c 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/component/linearsolver/iterative/ParallelCGLinearSolver.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/component/linearsolver/iterative/ParallelCGLinearSolver.cpp @@ -61,7 +61,7 @@ ParallelCGLinearSolver< ParallelCompressedRowSparseMatrixMechanicalregisterObjects(sofa::core::ObjectRegistrationData("Linear system solver using the conjugate gradient iterative algorithm in parallel.") + factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel version of the linear solver using the conjugate gradient iterative algorithm.") .add< ParallelCGLinearSolver< ParallelCompressedRowSparseMatrixMechanical, sofa::linearalgebra::FullVector > >(true) .add< ParallelCGLinearSolver< ParallelCompressedRowSparseMatrixMechanical>, sofa::linearalgebra::FullVector > >()); } diff --git a/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelHexahedronFEMForceField.cpp b/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelHexahedronFEMForceField.cpp index b1c44316565..e1d5b7c737a 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelHexahedronFEMForceField.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelHexahedronFEMForceField.cpp @@ -36,7 +36,7 @@ const bool isParallelHexahedronFEMForceFieldImplementationRegistered = void registerParallelHexahedronFEMForceField(sofa::core::ObjectFactory* factory) { - factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel hexahedral finite elements.") + factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel implementation of a linear elastic material using hexahedral finite elements.") .add < ParallelHexahedronFEMForceField < Vec3Types > > ()); } diff --git a/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelTetrahedronFEMForceField.cpp b/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelTetrahedronFEMForceField.cpp index 62afdba8add..cc0d876f5fa 100644 --- a/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelTetrahedronFEMForceField.cpp +++ b/applications/plugins/MultiThreading/src/MultiThreading/component/solidmechanics/fem/elastic/ParallelTetrahedronFEMForceField.cpp @@ -36,7 +36,7 @@ const bool isParallelTetrahedronFEMForceFieldImplementationRegistered = void registerParallelTetrahedronFEMForceField(sofa::core::ObjectFactory* factory) { - factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel tetrahedral finite elements.") + factory->registerObjects(sofa::core::ObjectRegistrationData("Parallel implementation of a linear elastic material using tetrahedral finite elements..") .add < ParallelTetrahedronFEMForceField < Vec3Types > > ()); }