Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup-Events können nun in die Softwerkskammer gespiegelt werden #1362

Merged
merged 14 commits into from
Aug 3, 2018

Conversation

NicoleRauch
Copy link
Member

Aktuell nur manuell möglich (pro Gruppe auf der Gruppenseite oder global auf der Aktivitätenseite).
Nach Testbetrieb sollte der Import zusätzlich durch einen Cronjob automatisiert werden.

Siehe Issue #1319 .

.form-group
+controlLabel(name, label, tooltip)
textarea(class=classname, id=name, rows=rowCount, type='text', name=name, placeholder=placeholder) #{value}
textarea(class=classname, id=name, rows=rowCount, type='text', name=name, placeholder=placeholder, disabled=readonly) #{value}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muss readonly jetzt immer gesetzt werden? - Sonst steht da readonly = undefined...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wo steht das? Im fertigen HTML sehe ich nix davon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Ich hätte das vermutet, wenn man es nicht setzt...

.form-group
+controlLabel('preview', 'Preview')
#map.hidden-print(style='width: ' + '100%' + '; height: ' + '420px')
.form-group
label.control-label(for='assignedGroup') #{t('groups.group')}:
select#assignedGroup.form-control.enhance(name='assignedGroup')
select#assignedGroup.form-control.enhance(name='assignedGroup', disabled=activity.clonedFromMeetup())
for group in groups
option(value=group.id, selected = (activity.assignedGroup() != undefined && activity.assignedGroup() == group.id)) #{group.longName}
.row
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier willst Du "readonly" setzen wenn aus Meetup. Richtig?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich glaube, dass das hier kein Mixin ist, sondern eine Pug-Komponente, deswegen will ich hier disabled setzen.

a.btn.btn-default(href=webcalURL, title=t('activities.export_subscribe')): i.fa.fa-calendar.fa-fw
if (accessrights.canCreateActivity())
a.btn.btn-default(href='new/', title=t('activities.new')): i.fa.fa-file-o.fa-fw
form(role='form', method='POST', action='clone-from-meetup/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum das Form um alles herum? - Ich fände es besser, wenn es nur um den Meetup button ist

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hab ich probiert, aber dann wird die Buttonleiste unterbrochen (also in zwei Stücke gehackt). Wenn Du das reparieren kannst, ändere ich das gern wieder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

async.each(groups, this.cloneActivitiesFromMeetupForGroup, callback);
});
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Modul ist nur für Meetup, oder? - Dann fände ich einen Namen, der dies wiederspiegelt, besser

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guter Punkt. commit ist unterwegs.

@leider leider merged commit 95ed54e into softwerkskammer:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants