Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][Settings] Introduce promotion category creation and modification capability #6102

Open
chaimann opened this issue Feb 7, 2025 · 3 comments · May be fixed by #6101
Open

[Admin][Settings] Introduce promotion category creation and modification capability #6102

chaimann opened this issue Feb 7, 2025 · 3 comments · May be fixed by #6101
Assignees

Comments

@chaimann
Copy link
Contributor

chaimann commented Feb 7, 2025

Description

Implement the functionality to add/edit promotion categories.

We already have a promotion categories index page:

Image

We're missing a create/edit page that utilizes the new UI components, which could replace this part in a modal component:
Image

Features

  • Interface for defining promotion category name and code in a modal component.
@chaimann chaimann self-assigned this Feb 7, 2025
@chaimann chaimann converted this from a draft issue Feb 7, 2025
@chaimann chaimann linked a pull request Feb 7, 2025 that will close this issue
6 tasks
@fthobe
Copy link
Contributor

fthobe commented Feb 7, 2025

Hey Chaimann,

thank you for your request. A migration to the new promotion system is undergoing.

Please consult following articles:
https://solidus.io/blog/solidus-v4-4 with the news about the new promotion system;
https://github.com/solidusio/solidus/blob/main/promotions/README.md with the readme.md of the new promotion system
https://github.com/solidusio/solidus/blob/main/promotions/MIGRATING.md with the migration guide

We are in the process of upgrading the documentation to account for the new promotion system. Old promotion bugs / feature requests will not be fixed.

@mamhoff
Copy link
Contributor

mamhoff commented Feb 10, 2025

He's talking about adding features for the new admin. Promotion categories work almost exactly the same for both systems, so I think a PR for either system will have good chances of being merged.

@chaimann
Copy link
Contributor Author

@fthobe @mamhoff hey guys, I'm indeed working on new admin UI, PR for this issue in particular will convert existing add/edit functionality to use modal forms instead of dedicated pages (changes introduced in #6046)

and to mention, I'm picking tasks from the Solidus Admin project, so I converted a task from there into this issue, for better tracking purposes. Please let me know if this is not the desired flow, and tasks in projects should remain as "drafts" 😄

@chaimann chaimann linked a pull request Feb 11, 2025 that will close this issue
6 tasks
@chaimann chaimann moved this from In Progress to Review in Solidus Admin Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

3 participants