Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.5] Better Spree::UserAddress scope deprecation warnings #6165

Merged
merged 2 commits into from
Feb 27, 2025
Merged

[v4.5] Better Spree::UserAddress scope deprecation warnings #6165

merged 2 commits into from
Feb 27, 2025
+3 −7

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.5:

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Better Spree::UserAddress scope deprecation warnings
80acf79 
Without the class and scope name it is very hard to
find the offending code.

(cherry picked from commit 7b701a1)
@tvdeyen
Fix rubocop offenses
7115685 
(cherry picked from commit 12b4db2)
@github-actions github-actions bot requested a review from a team as a code owner February 26, 2025 21:53
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem labels Feb 26, 2025
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (8e12a69) to head (7115685).
Report is 3 commits behind head on v4.5.

Files with missing lines Patch % Lines
core/app/models/spree/user_address.rb 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             v4.5    #6165   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         835      835           
  Lines       18150    18150           
=======================================
  Hits        16122    16122           
  Misses       2028     2028

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 23904a8 into v4.5 Feb 27, 2025
17 of 18 checks passed
@tvdeyen tvdeyen deleted the backport/v4.5/pr-6163 branch February 27, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees

@tvdeyen tvdeyen

Labels
changelog:solidus_core Changes to the solidus_core gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tvdeyen