-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't compile on esp-idf 5.3 #181
Comments
It looks like this is a bug on the ESP-IDF side.
Up until commit dca7c286d009024d8bacab52425c93a91ffc49c7, the version that was in /components/soc/include/soc/uart_periph.h did contain the expected definition, but was removed. Commit found here |
@tresler good catch, I also had to go back to the esp-idf 5.1 version because of this. I have implemented the same changes in this branch but conditionally only for v.5.3 and higher. I also left out the format changes so it's easier to see what has actually happened. I have not read up on the actual changes in the esp-idf why I have no real opinion on the correctness or completeness of the fix but I have tested with esp-idf v5.1.4 and v5.3.2 on an ESP32-S3 board and it works fine. Big thanks to @davispolito for your input. @someweisguy let me know if you want a PR on this fix. Maybe someone can help with validation on more boards? |
Just realized that @davispolito already has subitted a PR (#187) with his changes... |
C:/Users/juanp/OneDrive/Documentos/Digital-dots/firmware-lights/components/esp_dmx/src/dmx/hal/uart.c: In function 'dmx_uart_init': C:/Users/juanp/OneDrive/Documentos/Digital-dots/firmware-lights/components/esp_dmx/src/dmx/hal/uart.c:330:51: error: 'uart_signal_conn_t' has no member named 'module' 330 | periph_module_enable(uart_periph_signal[dmx_num].module); | ^ C:/Users/juanp/OneDrive/Documentos/Digital-dots/firmware-lights/components/esp_dmx/src/dmx/hal/uart.c:338:52: error: 'uart_signal_conn_t' has no member named 'module' 338 | periph_module_reset(uart_periph_signal[dmx_num].module); | ^ C:/Users/juanp/OneDrive/Documentos/Digital-dots/firmware-lights/components/esp_dmx/src/dmx/hal/uart.c: In function 'dmx_uart_deinit': C:/Users/juanp/OneDrive/Documentos/Digital-dots/firmware-lights/components/esp_dmx/src/dmx/hal/uart.c:384:56: error: 'uart_signal_conn_t' has no member named 'module' 384 | periph_module_disable(uart_periph_signal[uart->num].module);
The text was updated successfully, but these errors were encountered: