[dut_console]: conditionally skip connect tests for arista 7800 chassis #15520
Conversation
Signed-off-by: Liam Kearney <[email protected]>
| @@ -618,6 +618,18 @@ dut_console: | |||
| conditions: | |||
| - "asic_type in ['vs']" | |||
|
|
|||
| dut_console/test_console_baud_rate.py::test_baud_rate_boot_connect: | |||
There was a problem hiding this comment.
Current conditonal mark rule is:
- If markers are different: add all matched markers
- If markers are the same: add the marker matches the longest match
In this scenario, your marker is skip, just like the above skip in dut_console/, so when running test dut_console/test_console_baud_rate.py::test_baud_rate_boot_connect, the conditional marke added in dut_console/ would be invalid, which caused PR test failed, so please also add the condition "asic_type in ['vs']" defined in dut_console/
There was a problem hiding this comment.
sure thing, thanks. Fixed
| conditions: | ||
| - "'arista_7800' in platform" | ||
|
|
||
| dut_console/test_console_baud_rate.py::test_baud_rate_sonic_connect: |
|
@yutongzhang-microsoft since all tests under dut_console/ should be skipped in vs platform, should we move console tests from pr_test yaml to pr_skip yaml? Conditional mark could keep because we may have some local KVM tests |
Why we skip them? They are in PR checkers |
You skipped them with PR #5708 |
Description of PR
Skip dut console connect tests for arista 7800 as the linecards do not have console ports
Summary:
Fixes #15518
Type of change
Back port request
Approach
What is the motivation for this PR?
Test was failing on setup due to no mgmt ip for console, as there isnt a console for the linecards
How did you do it?
conditionally skip for 7800 chassis
How did you verify/test it?
ran locally, tests are skipped
Any platform specific information?
arista 7800 specific
Supported testbed topology if it's a new test case?
Documentation