Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer of same field subscribed to different DBs to have DBs/TABLE check prior to processing event #259

Open
shyam77git opened this issue May 2, 2022 · 3 comments

Comments

@shyam77git
Copy link

While reviewing CMIS PR changeset - #254 , found following issue:

Issue: Field with same naming on different Table across State/APPL DB is having conflict when an event is occurred.
(a) Port table in APPL DB – caters to speed, lane admin status etc. changes
(b) Port table in STATE DB – caters to host_tx_ready , admin status etc. changes
admin status change is found false in one table and true in another when config interface on a port/interface was applied.

Plan: Reviewed this with @prgeor
Need to add DB type check when an event is received.
Also, investigated and correct as to why this field (admin status and any other field) is in mismatch between the two tables.

@prgeor
Copy link
Collaborator

prgeor commented May 12, 2022

@shyam77git admin_status is fixed here sonic-net/sonic-swss#2233. Please do note, keeping same field values across STATE_DB, APPL_DB is outside the scope of Xcvrd. Please raise an issue in SWSS repo for having consistent field values across these DBs.

@shyam77git
Copy link
Author

Filed this issue to handle: Two DBs can have same field with different definition, So the consumer/event handler needs to take care of handling fields with same name across different DBs/TABLEs via DB/TABLE check

@prgeor
Copy link
Collaborator

prgeor commented May 16, 2022

Filed this issue to handle: Two DBs can have same field with different definition, So the consumer/event handler needs to take care of handling fields with same name across different DBs/TABLEs via DB/TABLE check

@shyam77git can you give me an example where two DBs have same field with different definition/meaning?

@shyam77git shyam77git changed the title Field (e.g. admin status change) is having conflict across STATE, APPL DBs - when updated Consumer of same field subscribed to different DBs to have DBs/TABLE check prior to processing event May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants