Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding adding extra param on sonic acl- orchagent exported API to SAI layer #1195

Open
satyakgec opened this issue Jan 13, 2023 · 0 comments

Comments

@satyakgec
Copy link

Hi,
“sai_acl_api->create_acl_table” call SAI api which calls Broadcom sdk-API(we are using Broadcom chip) to create group in ASIC.
We want to return group id back to SONIC. For that we want to add one extra argument(gidval) in the below API:
sai_acl_api->create_acl_table(&m_oid, &gidval, gSwitchId, (uint32_t)table_attrs.size(), table_att rs.data());

We did following changes:

  1. Above argument addition in “create_acl_table”
  2. Declaring variable gidval in “class AclTable” in aclorch.h
  3. Adding arg in “typedef sai_status_t (*sai_create_acl_table_fn)” inside “sonic-sairedis/SAI/inc/saiacl.h”

But we are getting some compilation error. But before coming to the errors can you inform whether any other change is required for this support ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant