-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --path
option to commands like validate
#218
Comments
See #80 |
Hey @jviotti , shall I pick this up? |
@Karan-Palan Yeah, feel free to go ahead and let me know if you have any questions. The JSON Schema CLI is a thin wrapper around https://github.com/sourcemeta/core (our library that implements JSON, JSON Pointer, etc) and https://github.com/sourcemeta/blaze (our JSON Schema validator), so definitely check out their respective docs! |
Sure reading the docs |
@jviotti , I have created a PR-#220 that might solve this issue. However the checks are failing and I believe that is due to non-formatted code. I have used prettier to format the code, however after inspecting the errors, I found I need to format the code with clang. I got this command from stack overflow and used it, and got this in my terminal: This might be because I have chromium locally set up as well and might have overrides. This is my first c/c++ contribution hence I'm not aware of dev-tools used in this environment. Could you please help me through this so I can fix it and re-commit my changes after signing them? Also might be a good idea to update the docs about contributing (adding signed commits, branches etc for good practices) |
Hi @Karan-Palan ,
Assuming you mean https://prettier.io, that's a JS specific thing. We indeed use ClangFormat, and with a custom configuration file, so just calling
Not sure what OS you are using, but it's common to install ClangFormat through its PIP package. See how we do it in our CI pipelines: https://github.com/sourcemeta/jsonschema/blob/main/.github/workflows/test.yml#L41 |
I'm using Ubuntu 24 LTS. Thanks for the help, will fix it |
That option would take a JSON Pointer to say: "act on the schema located in this part of the input". It can be a low-hanging fruit to start allowing various of these commands to operate on OpenAPI spec.
The text was updated successfully, but these errors were encountered: