We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Mode object returned by solve(solver, k, polarisation) could be generalised
Mode
solve(solver, k, polarisation)
Currently it is assumed to be a frequency eigenmode
Mode(k0::Vector, frequency::Number, data::Vector...)
We should rename frequency to eigval, data to eigvec, and add a label string
frequency
eigval
data
eigvec
label
Mode(k0::Vector, eigval::Number, eigvec::Vector, label::String, ...)
solve(solver, k, polarisation) could return array of Mode(k0, eigval, eigvec, "Frequency")
Mode(k0, eigval, eigvec, "Frequency")
wilson_eigen() could return array of Mode(k0, eigval, eigvec, "Wilson loop eigenvalue")
wilson_eigen()
Mode(k0, eigval, eigvec, "Wilson loop eigenvalue")
The label field could be used by eg plot_band_diagram to automatically label the y-axis
plot_band_diagram
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The
Mode
object returned bysolve(solver, k, polarisation)
could be generalisedCurrently it is assumed to be a frequency eigenmode
We should rename
frequency
toeigval
,data
toeigvec
, and add alabel
stringsolve(solver, k, polarisation)
could return array ofMode(k0, eigval, eigvec, "Frequency")
wilson_eigen()
could return array ofMode(k0, eigval, eigvec, "Wilson loop eigenvalue")
The
label
field could be used by egplot_band_diagram
to automatically label the y-axisThe text was updated successfully, but these errors were encountered: