Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/update make_psfsmasks #122

Closed
4 tasks
mperrin opened this issue Dec 14, 2023 · 2 comments
Closed
4 tasks

refactor/update make_psfsmasks #122

mperrin opened this issue Dec 14, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mperrin
Copy link
Collaborator

mperrin commented Dec 14, 2023

Some ideas that may improve functionality or robustness for handling the PSF masks.

  • When starting spaceKLIP, at import time check to see if PSF masks have been generated, and either automatically invoke make_psfmasks or pop up an alert message informing the user to do so. (I.e. similar to the WebbPSF data version check code)
  • Include version information for PSF masks, since they rely on derived calibration information such as mask locations and filter shifts. We may want to force recomputing new versions of the psf masks after updates in that calibration information.
  • Optimize the list of which sets of filters and masks are iterated over for NIRCam. Currently it computes many impossible combinations using the SW filters for LW detector and vice versa (e.g. files like "NRCA2_MASK210R_F460M.fits"; you can't ever have F460M on NRCA2!)
  • More major refactor: Rather than precomputing all masks, write code to compute on the fly just the ones that are needed, e.g. `get_psfmask('NRCA2', 'MASK210R', 'F200W') would either load that file from disk, or compute it and create that mask if it doesn't exist already.
@mperrin mperrin added the enhancement New feature or request label Dec 21, 2023
@kammerje kammerje self-assigned this Jul 1, 2024
@kammerje
Copy link
Collaborator

kammerje commented Jul 1, 2024

This PR implements pulling the PSF masks directly from CRDS as the new default. This is possible now because the masks were corrected on CRDS. I think it makes the above obsolete?

@mperrin
Copy link
Collaborator Author

mperrin commented Jul 31, 2024

I believe this issue has been addressed by #117 , since now the PSF masks are pulled from CRDS.

@mperrin mperrin closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants