remove nmpfit in v 3.5

[nden]

It was deprecated in 3.4.13. Confirm that there is a release of stistools which does not use nmpfit.

[stscirij]

Searching stistools for 'nmpfit' gave no results. I think the only code that used it was mktrace, and that was fixed to use gfit.gfit1d instead.

[nden]

Yeah, I replaced the code in stistools. Someone else was supposed to enable the mktrace tests. Has that happened yet? @SaOgaz may know.

[nden]

@stscirij Actually the PR that replaces this code in stistools has not been merged yet - spacetelescope/stistools#37. it also looks like tests are not running yet.

[stscirij]

Ah, ok, I didn't realise that nmpfit was called by gfit.

[SaOgaz]

If I'm remembering this correctly, the mktrace tests are in stistools (confirmed this) but I believe Nadia's PR that takes out nmpfit was failing the tests and I wasn't sure why. I believe @nden was out of town at the time.

@nden, you should be good to rebase your PR for this and see if the tests are still failing.

[nden]

stistools hasn't been updated yet. #92 redefined nmpfit will be removed in v 3.5/

[pllim]

Maybe we should change the title of this issue to "move gfit and nmpfit to stistools" as per #138 (comment)