From c9fffe496ccf1b3e6a5faa9eb8ecf14e6ce3be6f Mon Sep 17 00:00:00 2001 From: Niels Vanpachtenbeke <10651054+Nielsvanpach@users.noreply.github.com> Date: Wed, 12 Jun 2024 12:44:31 +0200 Subject: [PATCH] run deadcode set --- rector.php | 16 +--------------- src/Commands/FindFilesCommand.php | 2 -- src/Tasks/Backup/Actions/CreateBackupAction.php | 2 +- 3 files changed, 2 insertions(+), 18 deletions(-) diff --git a/rector.php b/rector.php index 2cc7944..a299b1e 100644 --- a/rector.php +++ b/rector.php @@ -22,7 +22,7 @@ return RectorConfig::configure() ->withPaths(['config', 'resources', 'src']) ->withPhpSets(php82: true) - ->withPreparedSets(codeQuality: true, typeDeclarations: true) + ->withPreparedSets(deadCode: true, codeQuality: true, typeDeclarations: true) ->withSkip([ ReadOnlyPropertyRector::class, ClosureToArrowFunctionRector::class, @@ -31,18 +31,4 @@ CombineIfRector::class, FlipTypeControlToUseExclusiveTypeRector::class, ExplicitBoolCompareRector::class, - - /**ReturnNeverTypeRector::class, - OptionalParametersAfterRequiredRector::class, - ClosureToArrowFunctionRector::class, - FlipTypeControlToUseExclusiveTypeRector::class, - ExplicitBoolCompareRector::class, - EncapsedStringsToSprintfRector::class, - StaticClosureRector::class, - StaticArrowFunctionRector::class, - UseIncrementAssignRector::class, - PostIncDecToPreIncDecRector::class, - NullableCompareToNullRector::class, - AddArrowFunctionReturnTypeRector::class, - AddClosureVoidReturnTypeWhereNoReturnRector::class,*/ ]); diff --git a/src/Commands/FindFilesCommand.php b/src/Commands/FindFilesCommand.php index 13b10aa..f670144 100644 --- a/src/Commands/FindFilesCommand.php +++ b/src/Commands/FindFilesCommand.php @@ -51,7 +51,5 @@ protected function handleFoundFile(Collection $fileSearchResults) $this->comment($fileSearchResult->getAbsolutePath()); }); - - $this->output; } } diff --git a/src/Tasks/Backup/Actions/CreateBackupAction.php b/src/Tasks/Backup/Actions/CreateBackupAction.php index 7d7c27e..7b1f830 100644 --- a/src/Tasks/Backup/Actions/CreateBackupAction.php +++ b/src/Tasks/Backup/Actions/CreateBackupAction.php @@ -12,7 +12,7 @@ class CreateBackupAction protected $dispatchOnQueue = true; /** @var callable|null */ - protected $afterBackupModelCreated = null; + protected $afterBackupModelCreated; public function afterBackupModelCreated(callable $afterBackupModelCreated): self {