registerMediaConversions runs everytime a Media models loads - unnecessary?

[martinhschei]

I have this trait which i add to my models. As you can see there is some logic concerning video files.
My problem with this is that registerMediaConversions runs everytime i load a media model and for the media archive in my app this could be 100+ videos on a page load. This is kinda slow.

Have i done something wrong or is it correct that registerMediaConversions runs each time a model is loaded?

trait RegistersMediaConversions
{
	public function registerMediaConversions(Media $media = null)
    {
        if ($media->isVideo()) {
            if (MediaProber::file($media->getPath())->getDuration() > 20) {
                $this->addMediaConversion('thumb')->width(690)->height(435)->extractVideoFrameAtSecond(10)->nonQueued();
            } else {
                $conversion = $this->addMediaConversion('thumb')->width(690)->height(435)->extractVideoFrameAtSecond(0)->nonQueued();
            }
            return;
        }

        $this->addMediaConversion('thumb')->width(690)->height(435)->nonQueued();
    }
}

[martinhschei]

The "thumb" conversion is created when the file is uploaded so i think it's unnecessary to run this method each time the model loads if the conversation exists already.

The thumbnail is not updated when this methods runs if it already exists.

[VladimirVertushkov]

@martinhschei
Hello! Did you find the answer to this question?