Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatternTransformation._pipeline_results only set during calls to apply(). #1911

Open
philip-paul-mueller opened this issue Jan 29, 2025 · 0 comments

Comments

@philip-paul-mueller
Copy link
Collaborator

Because PatternTransformation, i.e. most of the data flow transformations, including MapFusion are called through the apply() function, that lacks the pipeline_results argument that apply_pass() has.
To make this argument available to such passes, PatternTransformation has this member _pipeline_results, that is set to the value of pipeline_results argument that was passed to the apply_pass() method.
However, this member is only set during the execution of apply(), but when can_be_applied() is run the value is None.

I do not see a reason why it has to be that way and would propose to change this, such that _pipeline_results is also set during can_be_applied().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant