Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save frames with 255 limit, always #59

Open
jdavid opened this issue Mar 18, 2019 · 0 comments
Open

Save frames with 255 limit, always #59

jdavid opened this issue Mar 18, 2019 · 0 comments

Comments

@jdavid
Copy link
Member

jdavid commented Mar 18, 2019

Right now the frame size can not be bigger than the payload size. This may cause problems.

For example, if we deploy a mote without any network module (or with 4G or Iridium) it will save frames up to 255 bytes long. If then we attach an XBee module it won't be able to send the saved frames, because the payload is only 73 bytes.

This task is to:

  • Set the frame size to 255 bytes, always. This can be more than the payload size (XBee) or less (Iridium).

  • When sending, if a frame is larger than the frame size, then split it, and send the fragments. Move to the next frame in the queue only when we've received the ack for the last fragment.

With this change we will loss a bit of network efficiency with the XBee, because if we send a fragment successfully but not the whole frame, then we will send the first fragment again next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant