Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #6

Open
rodrigoalvesvieira opened this issue Apr 13, 2013 · 3 comments
Open

Improve code quality #6

rodrigoalvesvieira opened this issue Apr 13, 2013 · 3 comments
Labels
continuous enhancement

Comments

@rodrigoalvesvieira
Copy link

This is not a to-do that might be done ASAP, but a continuous task and - in general - we should aim at making the code easier to maintain (even if we assume that there is not thousands of people interested)

The Oracle's Code Conventions for the Java TM Programming Language is a nice guide that might help us with this continuous task.
rodrigoalvesvieira pushed a commit that referenced this issue Apr 13, 2013
Removing unnecessary newlines and blank lines and white space. As adv…
bf4dcfa 
…ised in the Oracle Guide at http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html#475. Related to #6.
rodrigoalvesvieira pushed a commit that referenced this issue Apr 13, 2013
Removing useless blank space. Related to #6.
ea26786
gustavopinto pushed a commit to gustavopinto/groundhog that referenced this issue Apr 15, 2013
reorganizing project structure. related to spgroup#6
741af3e
@rodrigoalvesvieira
Copy link
Author

There is something else related to this issue that we can work to improve too: replace System.out.print/println calls with logger.info calls, which are actually appropriate for logging.

@gustavopinto
Copy link
Member

Other point: the extractor package has the Uncompressor interface, but no one class in this package are implementing it. Or remove the interface, which, I think, is not a good idea, or force all classes to implement it.

gustavopinto pushed a commit that referenced this issue Apr 19, 2013
updating exception treatment. related to #6
3d59179
@rodrigoalvesvieira
Copy link
Author

Interesting, hadn't noticed this before. I agree with forcing the implementation.

rodrigoalvesvieira pushed a commit that referenced this issue Apr 27, 2013
Adding missing documentation for some methods, fixing typos and remov…
6e078ca 
…ing unnecessary blank spaces/lines. Related to #6 and #20.
gustavopinto pushed a commit that referenced this issue Apr 28, 2013
removing unused class and few refactorings. related to #6
ea153c6
rodrigoalvesvieira pushed a commit that referenced this issue May 1, 2013
Adding this to instance methods to reference object properties. Relat…
22a36b5 
…ed to #6.
rodrigoalvesvieira pushed a commit that referenced this issue May 4, 2013
Partially commenting methods and removing hard-coded date string. Rel…
3c4e798 
…ated to #6 and #20.
rodrigoalvesvieira pushed a commit that referenced this issue May 4, 2013
Adding documentation to the br.ufpe.cin.groundhog.http package and ad…
35729c5 
…ding 'this' to the references to local object's properties. Related to #6 and #20.
gustavopinto pushed a commit that referenced this issue May 12, 2013
using gson to parse data from github api. related to #6
331843b
gustavopinto pushed a commit that referenced this issue May 17, 2013
improving log messages. #33 and #6
8414def
gustavopinto pushed a commit that referenced this issue May 17, 2013
few changes in the code. #33 and #6
7a9149f
rodrigoalvesvieira pushed a commit that referenced this issue Jun 13, 2013
Improving code. Related to #6
e592bc8
dnr2 pushed a commit that referenced this issue Jun 13, 2013
added gitHubOauthAcessToken to the searchUrl string. Related to #19 and
2d44748 
#6
gustavopinto pushed a commit that referenced this issue Jul 2, 2013
removing iterator and few more enhancements. #6
3eb0c9a
rodrigoalvesvieira pushed a commit that referenced this issue Jul 5, 2013
Starting work on Gson object attributes serialization
7dd60b2 
Sometimes the attribute name in the API differs from the attribute name in its correspondent class in Groundhog. Using SerializedName we can manage to solve any issues regarding these differences

More info at http://google-gson.googlecode.com/svn/tags/1.2.3/docs/javadocs/com/google/gson/annotations/SerializedName.html

Related to #6
rodrigoalvesvieira pushed a commit that referenced this issue Jul 5, 2013
Removing useless, redundant attribute from Project: followersCount. T…
27cb8c3 
…his attribute duplicates the watchersCount one.

Related to #6
rodrigoalvesvieira pushed a commit that referenced this issue Jul 5, 2013
Adding SerializedName annotations to PullRequest. Related to #6
5d8dcbb
rodrigoalvesvieira pushed a commit that referenced this issue Jul 5, 2013
Informs the creation date of the Milestone and adding updateAt attrib…
06d856a 
…ute. Related to #6
rodrigoalvesvieira pushed a commit that referenced this issue Jul 7, 2013
Adding SerializedName annotations to User class. Related to #6
f1066c6
rodrigoalvesvieira pushed a commit that referenced this issue Jul 7, 2013
Adding SerializedName annotations to Organization class. Related to #6
fc04547
gustavopinto pushed a commit that referenced this issue Jul 16, 2013
renaming classes. #6
c0bbd7f
rodrigoalvesvieira pushed a commit that referenced this issue Jul 18, 2013
Creating constant to represent the search for projects without limits…
ddf0f9f 
… with Groundhog. Related to #6
gustavopinto pushed a commit that referenced this issue Jul 18, 2013
removing static methods from project class. rel #6
6c12248
gustavopinto pushed a commit that referenced this issue Jul 18, 2013
one more attempt to fix broken tests. rel #6
3d8de46
gustavopinto pushed a commit that referenced this issue Jul 24, 2013
removing code used to answer research questions. rel #6
b515499
gustavopinto pushed a commit that referenced this issue Aug 6, 2013
fixing some troubles when downloading projects. r #6, #56
64e793a
gustavopinto pushed a commit that referenced this issue Aug 8, 2013
Updating parser interface and updating clients. #6
0a83cbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rodrigoalvesvieira @gustavopinto