Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line matching is imprecise for method bodies with duplicated lines #88

Open
pauloborba opened this issue Feb 14, 2020 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@pauloborba
Copy link
Member

The current implementation could lead to errors in method bodies that contain repeated lines as in

x=x+1;
y=m();
x=x+1;

We should carefully assess (how frequent are such errors? can we discard such scenarios from the analysis?) and document that, as it might impact the study results. We should do the same for any imprecision that might impact the study results.

I wonder if we could do better by, for example, recording the line contents and, for lines that appear more than once, the order in which they appear. For the example above, we would record (x=x+1,1) for the first line, (y=m(),0) for the second line, and (x=x+1,2) for the third line. And maybe this extra information could be used to eliminate or reduce imprecision.

Modified line lists should not be Set.

@pauloborba pauloborba added the bug Something isn't working label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants