Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for docutils 0.21 release #12209

Closed
chrisjsewell opened this issue Mar 27, 2024 · 7 comments · Fixed by #12267
Closed

Plan for docutils 0.21 release #12209

chrisjsewell opened this issue Mar 27, 2024 · 7 comments · Fixed by #12267
Labels
docutils Tags upstream Docutils issues type:task

Comments

@chrisjsewell
Copy link
Member

chrisjsewell commented Mar 27, 2024

docutils version 0.21cr1 has just been pre-released (https://pypi.org/project/docutils/0.21rc1/), with the plan to release 0.21 proper in ~two weeks (thanks @grubert!)

For changes see: https://docutils.sourceforge.io/HISTORY.html#changes-since-0-21-rc1
(you may notice me and @AA-Turner are mentioned as contributors 😁)

We already test against the HEAD of docutils and, from a quick look at the changelog, nothing jumps out at me as requiring any change to sphinx.
So perhaps it is just a case, of changing docutils>=0.18.1,<0.21 allow 0.21?
If so:

  1. Should this be done only in the next major sphinx release (8.x)?
  2. Should we drop support for docutils 0.18 and is there any "compatibility" code to remove?

cc @sphinx-doc/developers

@chrisjsewell chrisjsewell added the docutils Tags upstream Docutils issues label Mar 27, 2024
@picnixz
Copy link
Member

picnixz commented Mar 27, 2024

Personally, I don't mind it. However, even if we do change the requirement, we still don't have a PyPi release so... I'm not sure it would help a lot. But yes, I'd prefer making it in the next major version (just to be on the safe side).

There is some portion of the code that is 0.18 specific because of a bug in 0.18 and 0.18.1 (but not in 0.17 and not in 0.19) in sphinx.util.du19_footnotes. Otherwise, I think that between 0.18 and 0.19 there are not much differences so it should be fine. However, since I never checked this personally, I cannot say for sure that we will be incompatible for some reasons.

@grubert
Copy link

grubert commented Mar 27, 2024 via email

@picnixz
Copy link
Member

picnixz commented Mar 27, 2024

dropping 3.8 support and manpage output for references is in discussion

We don't really care about 3.8 support since we've already dropped it on our side, but do you mean that there won't be any reference nodes for manpage? (or am I misunderstanding something?)

@grubert
Copy link

grubert commented Mar 27, 2024 via email

@picnixz
Copy link
Member

picnixz commented Mar 27, 2024

there is no output for reference nodes from the manpage writer ... before
0.21
never was ... no one complained,
i had the question, how to typeset url-references in roff, open for long
time, no one cared

Oh I wasn't aware of that! we recently added this in Sphinx #12108 so I think we will continue supporting OSC8 (at least for Sphinx). I didn't work directly on the manpage builder but I don't know the effects if you remove the visit_references from the Translator class upstream (or if you choose to ignore it completely and leave an empty body method). AFAICT, currently visit_references seems to use \fI and \fP for such nodes. I'm not an expert for that area but I think if we handle references nodes ourselves in our custom writer, it should be fine, right?

By the way, is there a way to detect whether a terminal supports OSC 8 programatically or not? because if there is one, it would help us.

@grubert
Copy link

grubert commented Mar 28, 2024 via email

@grubert
Copy link

grubert commented Mar 30, 2024 via email

@AA-Turner AA-Turner linked a pull request Apr 11, 2024 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docutils Tags upstream Docutils issues type:task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants