Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SQLAlchemy 2.0 #477

Closed
soininen opened this issue Jan 21, 2025 · 0 comments · Fixed by #488
Closed

Support for SQLAlchemy 2.0 #477

soininen opened this issue Jan 21, 2025 · 0 comments · Fixed by #488
Assignees
@soininen

Comments

@soininen
Copy link
Collaborator

It should be relatively easy to migrate to SQLAlchemy 2.0 since we are now on 1.4 which is designated as a "stepping stone" for 2.0. Rough plan, hoping no major restructuring or roadblocks arise:

  • Check the migration instructions here
  • Enable deprecation warnings and set the SQLALCHEMY_WARN_20=1 environment variable as instructed in the link above
  • Run unit tests, fix all warnings
  • The unit tests should cover most things, but better do some stuff in Toolbox as well, like run a SpineOpt model
@soininen soininen self-assigned this Feb 7, 2025
soininen added a commit to spine-tools/spine-items that referenced this issue Feb 7, 2025
@soininen
Replace deprecated uses of URL() by URL.create()
59671d6 
Re spine-tools/Spine-Database-API#477
soininen added a commit to spine-tools/Spine-Toolbox that referenced this issue Feb 7, 2025
@soininen
Replace deprecated use of URL() by URL.create()
312cb4b 
Re spine-tools/Spine-Database-API#477
soininen added a commit that referenced this issue Feb 7, 2025
@soininen
Fix SQLAlchemy deprecation warnings, no functional changes
278871a 
Re #477
soininen added a commit that referenced this issue Feb 7, 2025
@soininen
Fix SQLAlchemy warnings, no functional changes
1611569 
Re #477
soininen added a commit that referenced this issue Feb 7, 2025
@soininen
Replace deprecated uses of URL() by URL.create()
64d0fbd 
Re #477
soininen added a commit that referenced this issue Feb 7, 2025
@soininen
Remove unused import
d89ef73 
Re #477
@soininen soininen mentioned this issue Feb 7, 2025
Merged
5 tasks
soininen added a commit that referenced this issue Feb 7, 2025
@soininen
Replace deprecated uses of URL() by URL.create()
96acb2d 
Re #477
soininen added a commit that referenced this issue Feb 7, 2025
@soininen
Remove unused import
f3a182f 
Re #477
soininen added a commit that referenced this issue Feb 10, 2025
@soininen
Add future=True to calls to create_engine()
ec3b17f 
This forces SQLAlchemy engines to accept SQLAlchemy 2.0 style calls
only.

Re #477
@soininen soininen mentioned this issue Feb 10, 2025
Merged
5 tasks
soininen added a commit that referenced this issue Feb 10, 2025
@soininen
Set future=True in calls to Session()/sessionamker()
934bb57 
This should be the last step on our way to SQLAlchemy 2.0 compatibility.

Re #477
@soininen soininen mentioned this issue Feb 10, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soininen soininen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More SQLAlchemy compatibility spine-tools/Spine-Database-API
1 participant
@soininen