Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input_number.predbat_set_reserve_min - a couple of suggestions #1901

Open
PianSom opened this issue Jan 23, 2025 · 1 comment
Open

input_number.predbat_set_reserve_min - a couple of suggestions #1901

PianSom opened this issue Jan 23, 2025 · 1 comment

Comments

@PianSom
Copy link

PianSom commented Jan 23, 2025

Is your feature request related to a problem? Please describe.
Not especially

Describe the solution you'd like
The docs - quite rightly - suggest changing this setting if there is a potential for a grid disruption eg a storm. However, the behaviour is not what I expected.

When changing this setting to eg 75% then that level is used as a minimum that the SoC will descend to, with three quarters of the battery charge left intact to allow for an expected unexpected event. However, if the current SoC is under 75% then it does not charge to that level. I had expected it would, and suggest that this is reasonable behaviour.

An additional suggestion - the battery setting names are very confusing and very similar. Perhaps this one could be renamed to input_number.predbat_emergency_soc_level (or something similar, which is more descriptive of use than behaviour)?

Describe alternatives you've considered
I did consider input_number.predbat_best_soc_keep and setting input_number.predbat_best_soc_keep_weight to a high level. I remain unclear as to whether this would have the same effect.

Additional context
None

@gcoan
Copy link
Collaborator

gcoan commented Jan 23, 2025

@springfall2008 I have updated the documentation to explain a bit more the current behaviour of how the min battery reserve works and that changing it doesn't cause the battery to charge.

https://github.com/gcoan/batpred/blob/main/docs/customisation.md

Will be in my next PR.

r/e changing the name of this sensor, it's named based on what it does, it sets the minimum battery reserve level which is GivEnergy inverter terminology. For other non-GE inverters it probably doesn't make as much sense, but it is consistent with its GE heritage. Of course it requires a level of understanding of GE inverter terminology; I'm not sure emergency soc level is as descriptive as to its function. But anyway, for discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants