Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<1 particles per second #49

Closed
movitto opened this issue May 21, 2014 · 2 comments
Closed

<1 particles per second #49

movitto opened this issue May 21, 2014 · 2 comments

Comments

@movitto
Copy link

movitto commented May 21, 2014

Hey what were your thoughts on supporting emitters that emit fewer that 1 particles per second. The current Group#addEmitter implementation defines particles per second like so (when duration isn't specified):

emitter.particlesPerSecond = emitter.particleCount / that.maxAge | 0

When particleCount > maxAge (eg more than one particle per second) the bitwise-or clears the decimal / rounds the pps down to the nearest int (was this intended or should it be a ||?)

If particleCount < MaxAge this gets rounded to 0, resulting in no particle generation. Removing the bitwise-or in that case results in the intended effect, with the particles being generated at < 1 pps.

As always, thx for all the recent updates, they look great!

@squarefeet
Copy link
Owner

Hey @movitto - have a quick read of my comment on #48 before reading the rest of this :) You're more than welcome to get involved as well if you want to!

I agree about the <1pps thing... it's a limitation that shouldn't really exist. I'll add it to the roadmap!

@movitto
Copy link
Author

movitto commented Jun 14, 2014

Hey @squarefeet thx for the reply. Read through the start of the 2.0 stuff and looks good, will close and take it from there.

@movitto movitto closed this as completed Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants