Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit how to define an Emitter #2

Open
squarefeet opened this issue Nov 17, 2023 · 0 comments
Open

Revisit how to define an Emitter #2

squarefeet opened this issue Nov 17, 2023 · 0 comments
Assignees
@squarefeet
Labels
enhancement New feature or request

Comments

@squarefeet
Copy link
Owner

The Emitter class is currently not that great to adjust. It's a product of hacking away on something to get it working, and now is the time to think about end-user experience.

Requirements:

  1. Ease of Emitter construction
  2. Post-construction attribute modification

Possible avenues of exploration:

  1. Configuration object passed to constructor.
  2. A JSON configuration object being used to construct an Emitter (e.g. via Emitter.from( ... ))
  3. Helper methods on the Emitter's prototype to set attributes (initial value and distribution, modifiers, etc.)
  4. Separate Spawn, Position, and Velocity classes to define these attributes that are then passed to the Emitter
@squarefeet squarefeet added the enhancement New feature or request label Nov 17, 2023
@squarefeet squarefeet self-assigned this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squarefeet squarefeet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@squarefeet