Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Client.get_collection for static catalogs #782

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Fix Client.get_collection for static catalogs #782

merged 3 commits into from
Jan 31, 2025
+966 −1

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jan 31, 2025 •
edited
Loading

Related Issue(s):

Description:

  • add static catalog to test data (copied from pystac)
  • ensure that Client.get_collection returns specified collection
  • ensure that if no matching collection is found it raises

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@jsignell
Fix Client.get_collection for static catalogs:
11d894d 
* add static catalog to test data (copied from pystac)
* ensure that `Client.get_collection` returns specified collection
* ensure that if no matching collection is found it raises
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (21435b0) to head (70f8da2).
Report is 113 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   93.43%   94.08%   +0.64%     
==========================================
  Files          13       15       +2     
  Lines         990     1200     +210     
==========================================
+ Hits          925     1129     +204     
- Misses         65       71       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gadomski
gadomski requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a CHANGELOG.

pystac_client/client.py Show resolved Hide resolved
@jsignell jsignell requested a review from gadomski January 31, 2025 19:16
@jsignell jsignell enabled auto-merge (squash) January 31, 2025 19:42
@jsignell jsignell merged commit 1b16191 into stac-utils:main Jan 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_collection always returns last collection with a local catalog
3 participants
@jsignell @codecov-commenter @gadomski