Add beacon task in new project structure. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I think the following radio fields would be helpful: uint32_t rx_bytes;
uint32_t rx_packets;
uint32_t rx_backpressure_drops;
uint32_t rx_bad_packet_drops;
uint32_t tx_bytes;
uint32_t tx_packets;However I am concerned they will take too many bytes. Should be fine for now, can always lower precision in the future. Also, we can clean up structures like this one tmp_data[pkt_len++] = slate->time_in_current_state_ms & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 8) & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 16) & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 24) & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 32) & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 40) & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 48) & 0x11111111;
tmp_data[pkt_len++] = (slate->time_in_current_state_ms >> 56) & 0x11111111;Using a (By the way, is there a reason you used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added beacon task to run every 30s on running_state.
Currently only sends:
Other minor fixes in this PR: