Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move this package into the statechannels monorepo #66

Open
geoknee opened this issue Aug 13, 2021 · 1 comment
Open

move this package into the statechannels monorepo #66

geoknee opened this issue Aug 13, 2021 · 1 comment

Comments

@geoknee
Copy link
Contributor

geoknee commented Aug 13, 2021

For:

  • we use a monorepo; there's little point unless everything (or almost everything) lives inside
  • the usual upsides of a monorepo, including
    • we can make atomic commits across this package and (say) nitro-protocol
  • we can leverage existing publishing workflows instead of doing it manually as we have been doing

Against:

  • the usual downsides of monorepo, including
    • monorepo build time will increase (a bit)
  • it will be (a bit) more difficult for external folks to discover/understand this package if it is buried in a monorepo
  • it is more difficult to ensure the published package is not broken on npm (e.g. missing dependencies)
  • BUT... we don't yet have any external consumers of this package
@geoknee
Copy link
Contributor Author

geoknee commented Aug 13, 2021

(Another alternative is to absorb the code into nitro-protocol itself. But that might be a step too far?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant