Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify how executeSingleAssetExit and executeExit behave when an asset transfer fails. #72

Open
geoknee opened this issue Jun 28, 2022 · 0 comments
Open

Specify how executeSingleAssetExit and executeExit behave when an asset transfer fails. #72

geoknee opened this issue Jun 28, 2022 · 0 comments

Comments

@geoknee
Copy link
Contributor

geoknee commented Jun 28, 2022

Outside the scope of this PR, but somewhat higher priority because of it: we should specify how executeSingleAssetExit and executeExit behave when an asset transfer fails. I believe currently this will revert the entire transaction, which opens up griefing vectors where parties slip in "bad" assets and ruin things for everyone.

Originally posted by @geoknee in #69 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoknee