Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New onboarding: Seed Phrase Entry UX Issues #17105

Open
Tracked by #17097
glitchminer opened this issue Jan 21, 2025 · 6 comments · May be fixed by #17187
Open
Tracked by #17097

New onboarding: Seed Phrase Entry UX Issues #17105

glitchminer opened this issue Jan 21, 2025 · 6 comments · May be fixed by #17187
Assignees
Labels
bug Something isn't working core-team
Milestone

Comments

@glitchminer
Copy link
Contributor

Metadata

Issue 18 - Incorrect focus after paste

Field Description
Current Behavior After pasting, focus remains on the 11th, 16th or 21st field instead of the final one
Expected Behavior
Location/Screen Seed phrase entry
Figma URL

Issue 19 - Auto-focus behavior differs from design

Field Description
Current Behavior On completion of a valid word the focus is moved to the next field automatically
Expected Behavior Pressing enter moves to next field when valid
Location/Screen Seed phrase entry
Figma URL https://www.figma.com/design/Lw4nPYQcZOPOwTgETiiIYo/Desktop-Onboarding-Redesign?node-id=403-50297&m=dev

Issue 20 - Backspace behavior incorrect

Field Description
Current Behavior Double clicking a word so it is highlighted and pressing backspace deleted one character and opened the type-ahead suggestion menu instead of clearing the field
Expected Behavior Fields can be cleared by selecting a word and pressing backspace or delete
Location/Screen Seed phrase entry
Figma URL https://www.figma.com/design/Lw4nPYQcZOPOwTgETiiIYo/Desktop-Onboarding-Redesign?node-id=403-52841&m=dev
@caybro
Copy link
Member

caybro commented Jan 31, 2025

Ad Issue 19; I believe the behavior is correct (pressing Enter being equivalent to selecting the item with mouse), cf:

Image

@caybro caybro moved this from Next to In Progress in Status Desktop/Mobile Board Jan 31, 2025
@glitchminer
Copy link
Contributor Author

@caybro , for 19, the example you gave is fine but the issue is about the behaviour when return is pressed while the typeahead menu is not open.

Image

@caybro
Copy link
Member

caybro commented Jan 31, 2025

@caybro , for 19, the example you gave is fine but the issue is about the behaviour when return is pressed while the typeahead menu is not open.

Image

OK, this is definitely existing (and looks like intended) behavior; can you confirm @benjthayer ?

@caybro
Copy link
Member

caybro commented Jan 31, 2025

The other 2 issues are reproducible bugs, fixing.

@benjthayer
Copy link

benjthayer commented Feb 3, 2025

@caybro , for 19, the example you gave is fine but the issue is about the behaviour when return is pressed while the typeahead menu is not open.
Image

OK, this is definitely existing (and looks like intended) behavior; can you confirm @benjthayer ?

Sorry @caybro @glitchminer could you clarify the behaviour that is suggested to be incorrect so I can check?

I see when I go to add a new address using a recovery phrase, the recovery phrase form blocks the user from pressing enter if there is no valid word displayed via the typeahead menu. I think this is fine if we want to retain this behaviour - it stops the user from entering a wrongly spelled word accidentally and then having to go back through the form to fix the issues. Not sure if that was the question?

Of course the user should be able to enter an invalid word and click into another field which would then show the validation that the word previously entered is not valid.

@glitchminer
Copy link
Contributor Author

Hi @caybro @benjthayer , I think the question is about what this part means: "Pressing "Enter" validates the field. If entered word is valid, the next input is focused".

I understood it to mean that if you click into a field that already contains a valid word and press enter (without making any further edits) then the focus should move to the next field. The typeahead menu does not open in that case.

The user can still use the tab key to move forward but this would happen without the validation mentioned.

caybro added a commit that referenced this issue Feb 3, 2025
- fields can be cleared by selecting a word and pressing backspace or
delete

Iterates: #17105
@caybro caybro linked a pull request Feb 3, 2025 that will close this issue
2 tasks
@caybro caybro linked a pull request Feb 3, 2025 that will close this issue
2 tasks
@caybro caybro moved this from In Progress to Code Review in Status Desktop/Mobile Board Feb 3, 2025
caybro added a commit that referenced this issue Feb 5, 2025
- fields can be cleared by selecting a word and pressing backspace or
delete

Iterates: #17105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core-team
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

3 participants