Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry is submitting issues on debug builds #72

Open
jacobminer opened this issue Jul 20, 2021 · 3 comments
Open

Sentry is submitting issues on debug builds #72

jacobminer opened this issue Jul 20, 2021 · 3 comments

Comments

@jacobminer
Copy link
Contributor

Using the following config, it seems like Sentry is still sending bug reports:

clog.initWith(isDebug = BuildConfig.DEBUG, fileWritePath = externalCacheDir)
if (!BuildConfig.DEBUG) {
    clog.config.logLevel = LogLevelPreset.Release
}
@ssawchenko ssawchenko assigned jacobminer and munl and unassigned jacobminer Aug 16, 2021
@ssawchenko ssawchenko assigned ssawchenko and unassigned munl Sep 10, 2021
@ssawchenko
Copy link
Collaborator

ssawchenko commented Sep 10, 2021

I tried this out on the (debug) sample application and I cannot get reports to send to Sentry with the above configuration. Reports are only sent once I manually change the clog.config.logLevel to release or above.

We shouldn't need this chunk of code though:

if (!BuildConfig.DEBUG) {
    clog.config.logLevel = LogLevelPreset.Release
}

Steamclog should be setting this automatically for us during the initWith method call. @jacobminer if this chunk is still in the project would you mind removing it? Also, could you double check and make sure the BuildConfig.DEBUG property is behaving as expected.

@jacobminer
Copy link
Contributor Author

@ssawchenko Just tested this with and without that code. It looks like it's not submitting non-fatals, but will still submit a crash report if the app crashes. That's likely less to do with Steamclog and more to do with Sentry, but it would be nice if clog could configure Sentry to handle that as well.

@ssawchenko
Copy link
Collaborator

@ssawchenko Just tested this with and without that code. It looks like it's not submitting non-fatals, but will still submit a crash report if the app crashes. That's likely less to do with Steamclog and more to do with Sentry, but it would be nice if clog could configure Sentry to handle that as well.

Oh I see. Good point. I know there's a way to initialize Sentry programatically, perhaps there's a straightforward way to enable/disable it that way. Thank you for looking back into this for me :)

@ssawchenko ssawchenko removed their assignment Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants