Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latestTestVersion won't be respected if it is less than the current minimum version. #8

Closed
brendanlensink opened this issue Jan 20, 2021 · 2 comments
Assignees

Comments

@brendanlensink
Copy link
Contributor

I believe latestTestVersion is meant to allow developers/testers to use older versions of the app than is allowed with app store, but the current logic prevents it from ever working.

Lets assume:

  • Testing on version 1.1
  • Current app store release is 1.3
  • Minimum version is 1.2

Since blockedVersions is checked before latestTestVersion, and we're working on a build before the minimum version, we'll get the blocked version message and be forced to upgrade.

@nbrooke am I misunderstanding the latestTestVersion check or this a bug?

@nbrooke
Copy link
Member

nbrooke commented Jan 21, 2021

That's NOT the intended purpose of latestTestVersion (though what you describe is a feature that might be useful).

The idea there is to provide a way for beta versions to get a "there is a newer beta release out" notification (not as hard as a forced upgrade, you can click though it, but at least then clients / beta testers are less likely to keep running an old version). So the intended set up would be something more like:

Minimum version is 1.0
App store release is 1.1
Current ad hoc beta build is 1.2
latestTestVersion is 1.2

Any one with an ad hoc build of 1.1 or earlier would get a warning about having an out of date test version, until they either went to the app store 1.1 or got the latest 1.2 beta version. Note that this does require that test builds are #ifdef'd to set isTestBuild to true when creating the DefaultUpdateDisplay or handling the suggestUpdate event yourself if you aren't using that.

@nbrooke
Copy link
Member

nbrooke commented Jan 26, 2021

Added #10 and #11 with based on other discussions it sounds like are more the features that we actually want to address the potential use cases here, so closing this.

@nbrooke nbrooke closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants