Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/distributed create entity #1321

Merged
merged 33 commits into from
Feb 7, 2025
Merged

Feature/distributed create entity #1321

merged 33 commits into from
Feb 7, 2025

Conversation

thomasBousselin
Copy link
Contributor

@thomasBousselin thomasBousselin commented Jan 20, 2025 •
edited
Loading

Still missing :

  • test for EntityHandler create
  • test for DistributedEntityProvisionService

@github-actions github-actions bot added the feature New feature or request label Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Test Results

   71 files  + 1     71 suites  +1   1m 30s ⏱️ -1s
1 160 tests +12  1 160 ✅ +12  0 💤 ±0  0 ❌ ±0 
1 199 runs  +12  1 199 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit ee26f8d. ± Comparison against base commit aaf79ce.

This pull request removes 187 and adds 45 tests. Note that renamed tests count towards both. 
                           …, temporalRepresentation=TEMPORAL_VALUES, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…

com.egm.stellio.search.csr.model.ContextSourceRegistrationTests ‑ getAssociatedAttributes should check properties and relationship separately()
com.egm.stellio.search.csr.model.ContextSourceRegistrationTests ‑ getAssociatedAttributes should not get Attributes for non matching registrationInfo()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources  should return the remainingEntity()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should remove the attrs even when the csr is in error()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should return null if whole entity has been processed()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should return only non processed attributes()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should update the result()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ postDistributedInformation should process badly formed errors()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ postDistributedInformation should return a GatewayTimeout error if it receives no answer()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ postDistributedInformation should return the received error()
…

♻️ This comment has been updated with latest results.

@thomasBousselin thomasBousselin force-pushed the refactor/filter-attributes-signature branch 2 times, most recently from dc83f2a to 0942d7c Compare January 20, 2025 14:45
Base automatically changed from refactor/filter-attributes-signature to develop January 20, 2025 14:56
@thomasBousselin thomasBousselin force-pushed the feature/distributed-create-entity branch from 9dd9607 to 487d0a9 Compare January 20, 2025 14:57
bobeal
bobeal reviewed Jan 21, 2025
View reviewed changes
search-service/src/main/kotlin/com/egm/stellio/search/csr/model/CSRFilters.kt Outdated Show resolved Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/csr/model/ContextSourceRegistration.kt Outdated Show resolved Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ExpandedEntity.kt Outdated Show resolved Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/csr/model/ContextSourceRegistration.kt Outdated Show resolved Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ExpandedEntity.kt Outdated Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Outdated Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Outdated Show resolved Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt Show resolved Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt Outdated Show resolved Hide resolved
@thomasBousselin thomasBousselin linked an issue Jan 21, 2025 that may be closed by this pull request
implement csr for createEntity endpoint #1294
Closed
@thomasBousselin thomasBousselin self-assigned this Jan 21, 2025
@thomasBousselin thomasBousselin force-pushed the feature/distributed-create-entity branch from c785fa5 to a7699c4 Compare January 22, 2025 09:22
@thomasBousselin thomasBousselin marked this pull request as ready for review January 24, 2025 09:53
@thomasBousselin thomasBousselin added the csr Relates to context sources (registrations) API label Jan 24, 2025
bobeal
bobeal reviewed Feb 4, 2025
View reviewed changes
shared/src/main/kotlin/com/egm/stellio/shared/model/ExpandedEntity.kt Outdated Show resolved Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/BatchAPIResponses.kt Outdated Show resolved Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt Outdated Show resolved Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/BatchAPIResponses.kt Show resolved Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/BatchAPIResponses.kt Outdated Show resolved Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/csr/model/ContextSourceRegistration.kt Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Outdated Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Outdated Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Outdated Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Outdated Show resolved Hide resolved
@thomasBousselin
wip: removeattribute after csr call
0dee194
@thomasBousselin
wip: getFilteredAndRemoved on ExpandedEntity
f8d1dae
@thomasBousselin
feat: functionning call for distributeCreateEntity
a3928a2 
(missing error gestion and tests)
@thomasBousselin
feat: createEntity with error gestion
099433c
@thomasBousselin
fix: minor formating for pr
37a7af9
@thomasBousselin
fix: build
74bf13c
@thomasBousselin
fix: existing tests
fcfd294
@thomasBousselin
refactor: BatchEntityError.error as ProblemDetail
3a10c7e
@thomasBousselin
feat: first easy fixes
7da65b8
@thomasBousselin
feat: case when the entity is entirely merged + test for create entit…
bc78dbd 
…y handler
@thomasBousselin
fix: verify entity before distribution + accept non Problem Detail error
245ed78
@thomasBousselin
fix: case receive 207
4733f84
@thomasBousselin
refactor: rename InternalCsrFilter to RegistrationInfoFilter
04a5456
@thomasBousselin
refactor: put entity filter from the csr info in CSR class
060fae4
@thomasBousselin
fix: test on getAssociatedAttributes
4f93e3d
@thomasBousselin thomasBousselin force-pushed the feature/distributed-create-entity branch from 4ecbc64 to 5be9d25 Compare February 5, 2025 16:00
ranim-n
ranim-n reviewed Feb 6, 2025
View reviewed changes
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Show resolved Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt Show resolved Hide resolved
...h-service/src/test/kotlin/com/egm/stellio/search/csr/model/ContextSourceRegistrationTests.kt Outdated Show resolved Hide resolved
...src/test/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionServiceTests.kt Outdated Show resolved Hide resolved
...src/test/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionServiceTests.kt Outdated Show resolved Hide resolved
bobeal
bobeal reviewed Feb 7, 2025
View reviewed changes
...src/test/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionServiceTests.kt Outdated Show resolved Hide resolved
...src/test/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionServiceTests.kt
@Test
fun `postDistributedInformation should process badly formed errors`() = runTest {
val csr = gimmeRawCSR()
val path = "/ngsi-ld/v1/entities"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a future PR, we should extract these paths into constants, I see them popping a lot recently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i kind of start doing it for the delete entity.

...src/test/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionServiceTests.kt
Comment on lines +265 to +267
assertEquals(response.leftOrNull()?.type, ErrorType.BAD_GATEWAY.type)
assertEquals(response.leftOrNull()?.status, HttpStatus.BAD_GATEWAY)
assertEquals(response.leftOrNull()?.detail, invalidErrorResponse)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the asserts are not in the correct order (it is always (expected, actual))

...src/test/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionServiceTests.kt Outdated Show resolved Hide resolved
search-service/src/test/kotlin/com/egm/stellio/search/entity/web/EntityHandlerTests.kt Show resolved Hide resolved
search-service/src/test/kotlin/com/egm/stellio/search/entity/web/EntityHandlerTests.kt Outdated Show resolved Hide resolved
bobeal
bobeal approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@bobeal bobeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK once the last suggestions have been handled

thomasBousselin and others added 4 commits February 7, 2025 17:17
@thomasBousselin
fix: PR comments
439aecc
@thomasBousselin @bobeal
Update search-service/src/test/kotlin/com/egm/stellio/search/csr/serv…
0473491 
…ice/DistributedEntityProvisionServiceTests.kt

Co-authored-by: Benoit Orihuela <[email protected]>
@thomasBousselin
fix: detekt after suggestion
df06705
@thomasBousselin
Feature/local parameter (#1323)
ee26f8d 
* feat:support for local parameter

* feat:support for local parameter

* fix: apply local on true

* fix: apply local on true

* fix: apply local on true

* fix: apply local on true

* fix: issue with rebase

* fix: detekt after suggestion
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
66.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thomasBousselin thomasBousselin merged commit 65b2b21 into develop Feb 7, 2025
11 checks passed
@thomasBousselin thomasBousselin deleted the feature/distributed-create-entity branch February 7, 2025 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobeal bobeal bobeal approved these changes

@ranim-n ranim-n ranim-n approved these changes

Assignees

@thomasBousselin thomasBousselin

Labels
csr Relates to context sources (registrations) API feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement csr for createEntity endpoint
3 participants
@thomasBousselin @bobeal @ranim-n