join_feature, allow to select a slot (e.g. scaled, raw etc..)

[stemangiola]

No description provided.

[noriakis]

@stemangiola Hello, I would like to contribute to this feature. Would there be any specific consideration for this?
Thank you for maintaining this important project.

[stemangiola]

Amazing!

I think it is pretty straightforward.

for join_feature shape="wide" it works because I have updated the function get_abundance_sc_wide.

However, for shape="long" it does not because I have not updated the function get_abundance_sc_long with the right argument and used GetAssayData

[noriakis]

@stemangiola Thank you for your reply and instructions. I will make a pull request when the feature is ready.

[stemangiola]

@noriakis when you manage you first commit please add your authorship details here https://docs.google.com/spreadsheets/d/19XqhN3xAMekCJ-esAolzoWT6fttruSEermjIsrOFcoo/edit?usp=sharing

[stemangiola]

Thanks @noriakis for your PR!

[noriakis]

@stemangiola Thank you very much for merging the PR, and I have added the detail to the google spreadsheet.

[stemangiola]

@stemangiola Thank you very much for merging the PR.

Thanks to you, in case you were interested, as you already have experience in tidyseurat I just point to another cool challenge about adapting tidyseurat documentation to tidySingleCellExperiment

#66

Of course no expectations.

[noriakis]

Thank you for mentioning. Yes, I would very much like to contribute!

[stemangiola]

Thank you for mentioning. Yes, I would very much like to contribute!

Amazing, in that case, please make yourself notice in the challenge commenting. And I will assign you ;)

[stemangiola]

Just to make 100% sure, the goal would be to update tidyseurat, not tidySingleCellExperiment (which is your reference). :)

[noriakis]

@stemangiola Thank you for the clarification! Am I correct in understanding that I should be modifying tidyseurat documentation to be in line with the modification of tidySingleCellExperiment documentation, which has been discussed in #66?

[stemangiola]

@stemangiola Thank you for the clarification! Am I correct in understanding that I should be modifying tidyseurat documentation to be in line with the modification of tidySingleCellExperiment documentation, which has been discussed in #66?

correct