Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page action button (in address bar) does not display if tab is in no container at all #639

Open
nike4613 opened this issue Jul 14, 2024 · 0 comments

Comments

@nike4613
Copy link

  • Temporary Containers Version: 1.9.2
  • Firefox Version: 115.13.0 (Floorp 11.15.0)

Actual behavior

No page action button when tab does not have container

Expected behavior

The page action button to be present even when a tab is not in a container

Steps to reproduce

  1. Open a tab outside any containers (you can use the Sideberry extension, for instance, to do so)
  2. Observe lack of button, even with option enabled

Notes

It seems to be this code that causes the problem:

const container = await browser.contextualIdentities.get(
activatedTab.cookieStoreId
);

I see in the debug console for the background page this error:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant