You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
OK, #44 fixed blobs, but it broke mprpc in a different way 😢
According to the spec, the method name needs to be a UTF-8 string, not a binary object. If the client is running Python 2, the default string type is binary, and thus msgpack-python will serialize it as such when use_bin_type is set.
I'm not a Cython expert, but it seems like the issue is here:
OK, #44 fixed blobs, but it broke mprpc in a different way 😢
According to the spec, the method name needs to be a UTF-8 string, not a binary object. If the client is running Python 2, the default string type is binary, and thus msgpack-python will serialize it as such when
use_bin_type
is set.I'm not a Cython expert, but it seems like the issue is here:
mprpc/mprpc/client.pyx
Lines 123 to 128 in a7a05e6
The type of
method
isstr
, but that's an ambiguous type across Python version boundaries. In Python 2, it'll be binary, in Python 3, it'll be Unicode.The text was updated successfully, but these errors were encountered: