Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up the min required PHP version #212

Open
spacedmonkey opened this issue Jan 29, 2025 · 5 comments
Open

Up the min required PHP version #212

spacedmonkey opened this issue Jan 29, 2025 · 5 comments

Comments

@spacedmonkey
Copy link
Contributor

It is currently PHP 5.2. I think we should go to PHP 7.0 or PHP 7.2. Thoughts?

@JJJ
Copy link
Collaborator

JJJ commented Jan 31, 2025

Agree!

@spacedmonkey
Copy link
Contributor Author

I am of the camp of YOLO and just go to PHP 7.2. If you look at the stats, it is less than 5% is pre 7.2. There is 2.2 on PHP 5.6 still. But these would not get WordPress updates either. I can think it safe to go PHP 7.2. I could be talked out it. I would also bumb the min version supported to WP 6.0+ as well.

Thoughts @JJJ

@JJJ
Copy link
Collaborator

JJJ commented Jan 31, 2025

YOLO it is.

Plus, we haven't actually changed anything in the code itself yet that would break anything for anyone.

It seems like the polite thing to do!

@spacedmonkey
Copy link
Contributor Author

I plan to change this value

* Requires PHP: 5.2

This will mean it the version of PHP doesn't match, then the update will not install.

@lloc
Copy link
Contributor

lloc commented Feb 1, 2025

Looking at the supported PHP versions at PHP.net and the versions supported by WordPress 6.7, I would say PHP 7.2 should be the bare minimum.

WP Multi Network master could be tagged with the latest minor (2.5.3) and the upcoming changes go in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants