E2E: Use GetHealthCheckIP in gateway status test #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3291/tpantelis/gw_status_e2e |
This was referenced Jan 31, 2025
...instead of checking if HealthCheckIPs is populated for backwards compatibility if run on a Submariner installation that isn't running a version with the updated gateway code that sets HealthCheckIPs. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
gw_status_e2e
branch
from
9535360 to
0e3b406
Compare
yboaron
approved these changes
Feb 2, 2025
skitt
approved these changes
Feb 3, 2025
|
🤖 Closed branches: [z_pr3291/tpantelis/gw_status_e2e] |
tpantelis
added a commit
to tpantelis/subctl
that referenced
this pull request
Feb 3, 2025
...specifically to get submariner-io/submariner#3291 for the verify command. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/subctl
that referenced
this pull request
Feb 3, 2025
...specifically to get submariner-io/submariner#3291 for the verify command. Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of checking if
HealthCheckIPsis populated for backwards compatibility if run on a Submariner installation that isn't running a version with the updated gateway code that setsHealthCheckIPs.