diff --git a/.changeset/seven-brooms-impress.md b/.changeset/seven-brooms-impress.md new file mode 100644 index 00000000000..a845151cc84 --- /dev/null +++ b/.changeset/seven-brooms-impress.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/.circleci/config.yml b/.circleci/config.yml index 44938d6852b..6798355b2bf 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -144,6 +144,7 @@ workflows: - "16" - "18" - "20" + - "22" - "Check for FIXM\x45" - Prettier - ESLint diff --git a/packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts b/packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts index fa444f53132..bed9d2dfe68 100644 --- a/packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts +++ b/packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts @@ -141,12 +141,8 @@ Object.keys(schemes).forEach((schemeName) => { // idle connections in these versions. However, `Stopper` _is_ still // useful for gracefully finishing in-flight requests within the timeout // (and aborting requests beyond the timeout). - // - // (Node 18.19.0 had this change backported but it was removed again in - // 18.20.3; our tests only pin major versions so we can assume 18 means - // >= 18.20.3.) - const isNode20 = !!process.version.match(/^v20\./); - expect(closed).toBe(isNode20 ? 1 : 0); + const isNode20orGreater = !!process.version.match(/^v2\d\./); + expect(closed).toBe(isNode20orGreater ? 1 : 0); }); // This test specifically added for Node 20 fails for Node 14. Just going