Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributors guide #43

Closed
andygrove opened this issue Dec 16, 2022 · 2 comments
Closed

Add contributors guide #43

andygrove opened this issue Dec 16, 2022 · 2 comments

Comments

@andygrove
Copy link
Contributor

We should add a contributors guide, explaining bors, commit messages, release process, etc

@mbrobbel
Copy link
Member

I'll add this in the PR for #38.

@andygrove
Copy link
Contributor Author

bors docs: https://bors.tech/documentation/

bors bot pushed a commit that referenced this issue Jan 2, 2023
Closes #38 and #43.

With bors configured in this repository the flow is a bit different, but I think this should be a good setup to allow automating releases. Instead of requiring commit messages to follow the Conventional Commits specification, we just require the PR title to follow it, since that is what ends up being the commit message of the squash merge commit.

Overlaps with #47 so closing that one.
bors bot pushed a commit that referenced this issue Jan 13, 2023
Closes #38 and #43.

With bors configured in this repository the flow is a bit different, but I think this should be a good setup to allow automating releases. Instead of requiring commit messages to follow the Conventional Commits specification, we just require the PR title to follow it, since that is what ends up being the commit message of the squash merge commit.

Overlaps with #47 so closing that one.
bors bot pushed a commit that referenced this issue Jan 13, 2023
Closes #38 and #43.

With bors configured in this repository the flow is a bit different, but I think
this should be a good setup to allow automating releases. Instead of requiring
commit messages to follow the Conventional Commits specification, we just
require the PR title to follow it, since that is what ends up being the commit
message of the squash merge commit.

Overlaps with #47 so closing that one.
bors bot pushed a commit that referenced this issue Mar 13, 2023
Following the main Substrait repository: this makes the PR check match the Merge check by also checking the body of the PR.  

The PR comment note is moved to the [job summary](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary).

Added a note about the use of [`cargo-smart-release`](https://github.com/Byron/gitoxide/tree/main/cargo-smart-release) to the contributing guide.

Closes #55.
Closes #43.
bors bot pushed a commit that referenced this issue Mar 13, 2023
Following the main Substrait repository: this makes the PR check match the Merge
check by also checking the body of the PR.  

The PR comment note is moved to the [job
summary](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary).

Added a note about the use of
[`cargo-smart-release`](https://github.com/Byron/gitoxide/tree/main/cargo-smart-release)
to the contributing guide.

Closes #55. Closes #43.
@bors bors bot closed this as completed in 39e3441 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants