Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhythm maker erroneous behavior while rendering blocks. #2779

Closed
ricknjacky opened this issue Jan 27, 2021 · 15 comments
Closed

Rhythm maker erroneous behavior while rendering blocks. #2779

ricknjacky opened this issue Jan 27, 2021 · 15 comments
Labels
Issue-Regression Something that worked in the past is now broken

Comments

@ricknjacky
Copy link
Member

I recall testing the widget recently on GitHubPages of Musicblocks's master branch. It worked fine back then. Had some minor UI anomalies as discussed here

However now it showcases erratic behavior. Two rulers are expected. Instead, only one of them loads.

The new (erratic) behavior:-

image

The expected behavior:-

image

@meganindya
Copy link
Member

Something off with the width ... please check after the page is redeployed (after more changes are incorporated on master). This repo struggles with GH pages highlighted in #2632.

@ricknjacky
Copy link
Member Author

Something off with the width ... please check after the page is redeployed (after more changes are incorporated on master). This repo struggles with GH pages highlighted in #2632.

Sure, I will. However in #2777 you can clearly see that even my local system (one up to date with master branch)
doesn't load the second ruler. I presume, maybe we missed this while testing #2763 because it was working properly on my local system as well.
Your thoughts on this?

@meganindya
Copy link
Member

Looks alright on my local machine ... HEAD commit of master

@ricknjacky
Copy link
Member Author

Looks alright on my local machine ... HEAD commit of master

Oh, can you please tell me what am I missing here ?

Updated my local :-

Screenshot (538)

Even then, 2 rulers won't render
image

@meganindya
Copy link
Member

If your rebase your local master to current master ... HEAD is 2b381e7

@ricknjacky
Copy link
Member Author

If your rebase your local master to current master ... HEAD is 2b381e7

How do I fix this one, can you please guide? I am kind of confused here.

@meganindya
Copy link
Member

run git rev-parse HEAD and share output

@ricknjacky
Copy link
Member Author

Screenshot (539)

2b381e7bc685ad9b3ead614974d16d41a1c89642

@meganindya
Copy link
Member

git log -1

@ricknjacky
Copy link
Member Author

Screenshot (540)

@meganindya
Copy link
Member

You're at the right place

@meganindya
Copy link
Member

bf5b200a-895a-4507-844a-ad47edac8fec
looks right

@ricknjacky
Copy link
Member Author

ricknjacky commented Jan 28, 2021

bf5b200a-895a-4507-844a-ad47edac8fec
looks right

This is the exact same behavior on my local. And this is erratic.
I guess I didn't explain myself clearly here, I was pointing to 2 stripes of rulers that are expected. Only one of them is being rendered here. One for snare drum and one for kick drum are expected.

@meganindya
Copy link
Member

Right. This is a regression.

@meganindya meganindya added the Issue-Regression Something that worked in the past is now broken label Jan 28, 2021
@ricknjacky
Copy link
Member Author

fixed in #2793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Regression Something that worked in the past is now broken
Projects
None yet
Development

No branches or pull requests

2 participants