Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header: All menu navigation links should appear in the hamburger dropdown #2772

Open
alundgard opened this issue Dec 19, 2024 · 3 comments · May be fixed by #2809
Open

Header: All menu navigation links should appear in the hamburger dropdown #2772

alundgard opened this issue Dec 19, 2024 · 3 comments · May be fixed by #2809
Assignees
@dnoneill

Comments

@alundgard
Copy link
Member

Currently, only the top-level navigation links appear in the hamburger. The lower-level links appear below the title.
https://exhibits.stanford.edu/martin-wong
Image

We'd like all of the navigation links to appear in the hamburger. As an example, see the Archives implementation.
Image

This is already implemented in the component library. See example: https://sul-dlss.github.io/component-library/header/.
Image
@alundgard alundgard mentioned this issue Dec 18, 2024
Open
6 tasks
@dnoneill dnoneill assigned dnoneill and unassigned dnoneill Dec 20, 2024
@dnoneill
Copy link
Contributor

dnoneill commented Jan 9, 2025

@alundgard Should the mobile menu also open under the title or should it appear as it is?

@alundgard
Copy link
Member Author

Yes there is a separate issue for that: sul-dlss/component-library#39.

@dnoneill
Copy link
Contributor

dnoneill commented Jan 9, 2025

I would wait for sul-dlss/component-library#86 to be merged (there could be changes after review) before addressing this ticket. The code should be easy to implement once it is in the component library.

@dnoneill dnoneill self-assigned this Jan 15, 2025
@dnoneill dnoneill linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnoneill dnoneill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

have all navigation links appear in mobile menu, move mobile menu to … sul-dlss/exhibits
2 participants
@alundgard @dnoneill