Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route property must be named url #261

Open
Prokyonn opened this issue Jul 26, 2024 · 0 comments
Open

Route property must be named url #261

Prokyonn opened this issue Jul 26, 2024 · 0 comments
Labels
To Discuss The core team has to decide if this will be implemented

Comments

@Prokyonn
Copy link
Member

Currently the SuluContentBundle forces the user to have the route property named url in the template.

This behaviour is not consistent throughout Sulu. The ArticleBundle did not force you to have to property named url usually it was called routePath.

Therefore migrating the ArticleBundle to the ContentBundle requires also a migration of the XML templates.

Possible solution

  • Add the required steps to the UPGRADE.md.
  • Add a MetadataListener that shows an error in the UI when an entity detail page is opened with a route property that is not named url.
  • Force a url property in the template structure e.g.:
sulu_core:
    content:
        structure:
            required_properties:
                home:
                    - title
                    - url
@Prokyonn Prokyonn added the To Discuss The core team has to decide if this will be implemented label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To Discuss The core team has to decide if this will be implemented
Projects
None yet
Development

No branches or pull requests

1 participant