From bd06fdb4f42cf0522757e7ebc00033169599b1d6 Mon Sep 17 00:00:00 2001 From: Torsten Bergmann Date: Tue, 28 May 2024 18:58:59 +0200 Subject: [PATCH 1/2] Cleanup: ZnCharacterEncoder, ZnEncodedStream, ZnEncodedReadStream and ZnEncodedWriteStream should be abstract classes Fix #139 and https://github.com/pharo-project/pharo/issues/16708 --- .../ZnCharacterEncoder.class/class/isAbstract.st | 4 ++++ .../ZnEncodedReadStream.class/class/isAbstract.st | 4 ++++ .../ZnEncodedStream.class/class/isAbstract.st | 4 ++++ .../ZnEncodedWriteStream.class/class/isAbstract.st | 4 ++++ .../monticello.meta/categories.st | 2 +- 5 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 repository/Zinc-Character-Encoding-Core.package/ZnCharacterEncoder.class/class/isAbstract.st create mode 100644 repository/Zinc-Character-Encoding-Core.package/ZnEncodedReadStream.class/class/isAbstract.st create mode 100644 repository/Zinc-Character-Encoding-Core.package/ZnEncodedStream.class/class/isAbstract.st create mode 100644 repository/Zinc-Character-Encoding-Core.package/ZnEncodedWriteStream.class/class/isAbstract.st diff --git a/repository/Zinc-Character-Encoding-Core.package/ZnCharacterEncoder.class/class/isAbstract.st b/repository/Zinc-Character-Encoding-Core.package/ZnCharacterEncoder.class/class/isAbstract.st new file mode 100644 index 00000000..ef117b02 --- /dev/null +++ b/repository/Zinc-Character-Encoding-Core.package/ZnCharacterEncoder.class/class/isAbstract.st @@ -0,0 +1,4 @@ +testing +isAbstract + + ^ self == ZnCharacterEncoder \ No newline at end of file diff --git a/repository/Zinc-Character-Encoding-Core.package/ZnEncodedReadStream.class/class/isAbstract.st b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedReadStream.class/class/isAbstract.st new file mode 100644 index 00000000..7b5ef11e --- /dev/null +++ b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedReadStream.class/class/isAbstract.st @@ -0,0 +1,4 @@ +testing +isAbstract + + ^ self == ZnEncodedReadStream \ No newline at end of file diff --git a/repository/Zinc-Character-Encoding-Core.package/ZnEncodedStream.class/class/isAbstract.st b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedStream.class/class/isAbstract.st new file mode 100644 index 00000000..0a22e299 --- /dev/null +++ b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedStream.class/class/isAbstract.st @@ -0,0 +1,4 @@ +testing +isAbstract + + ^ self == ZnEncodedStream \ No newline at end of file diff --git a/repository/Zinc-Character-Encoding-Core.package/ZnEncodedWriteStream.class/class/isAbstract.st b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedWriteStream.class/class/isAbstract.st new file mode 100644 index 00000000..3ed952fd --- /dev/null +++ b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedWriteStream.class/class/isAbstract.st @@ -0,0 +1,4 @@ +testing +isAbstract + + ^ self == ZnEncodedWriteStream \ No newline at end of file diff --git a/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st b/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st index 2cb3537b..f2721d0c 100644 --- a/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st +++ b/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st @@ -1 +1 @@ -SystemOrganization addCategory: #'Zinc-Character-Encoding-Core'! +self packageOrganizer ensurePackage: #'Zinc-Character-Encoding-Core' withTags: #()! From b0c3be423c150372399f97a2b4aab8f73d35190b Mon Sep 17 00:00:00 2001 From: Astares Date: Tue, 28 May 2024 20:55:38 +0200 Subject: [PATCH 2/2] Update categories.st --- .../monticello.meta/categories.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st b/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st index f2721d0c..2cb3537b 100644 --- a/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st +++ b/repository/Zinc-Character-Encoding-Core.package/monticello.meta/categories.st @@ -1 +1 @@ -self packageOrganizer ensurePackage: #'Zinc-Character-Encoding-Core' withTags: #()! +SystemOrganization addCategory: #'Zinc-Character-Encoding-Core'!