Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler performance smoke tests are currently broken #78654

Open
jamieQ opened this issue Jan 15, 2025 · 3 comments · May be fixed by swiftlang/swift-source-compat-suite#965
Open

Compiler performance smoke tests are currently broken #78654

jamieQ opened this issue Jan 15, 2025 · 3 comments · May be fixed by swiftlang/swift-source-compat-suite#965
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. continuous integration performance

Comments

@jamieQ
Copy link
Contributor

jamieQ commented Jan 15, 2025 •
edited
Loading

Description

the swift-ci job that run when you invoke @swift-ci Please smoke test compiler performance appears to currently be broken (and likely has been for some time). as shown here, at least one of the projects in the suite is trying to check out a non-existent commit from the target repository, which causes the job to fail.

a potential fix is to adjust each configuration to ensure the commits reference release tags in the repo (which hopefully should 'always' exist).

Reproduction

invoke the job on an open PR to see the issue

Expected behavior

the job should successfully check out the performance testing suite targets (and ideally run to completion)

Environment

n/a

Additional information

No response
@jamieQ jamieQ added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels labels Jan 15, 2025
@finagolfin finagolfin added performance continuous integration and removed triage needed This issue needs more specific labels labels Jan 16, 2025
@finagolfin
Copy link
Member

The source compat suite is open source: can you submit a fix, if you know what the problem is?

@xedin
Copy link
Contributor

xedin commented Jan 16, 2025

*could you please

@jamieQ jamieQ linked a pull request Jan 16, 2025 that will close this issue
Open
@jamieQ
Copy link
Contributor Author

jamieQ commented Jan 17, 2025

attempt at a minimal solution to this is here: swiftlang/swift-source-compat-suite#965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. continuous integration performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore]: update cperf Kingfisher entry to try and fix build jamieQ/swift-source-compat-suite
3 participants
@xedin @jamieQ @finagolfin