Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The description of the plugin can't be translated via translate.wp.org #883

Closed
NekoJonez opened this issue Dec 14, 2023 · 8 comments
Closed

Comments

@NekoJonez
Copy link

Like the title says. I looked for it and don't see how I can solve it by myself...

image

@swissspidy
Copy link
Owner

Hiya, what do you mean exactly? Don‘t you see the string on the translate.wordpress.org site, or is it simply not being translated correctly? The screenshot doesn‘t show anything unusual.

@NekoJonez
Copy link
Author

Heh, I thought I wrote more in my ticket... Seems I remeber things wrong.

Now, it isn't present in the translation platform. Usually when I notice things like these... I go into the code and look for the function that places the string. Yet, I think its in JS... And I dont know how translations work in there. Thats what that screenshot was.

Anyways, I was doing a lot of things at once when I made this issue... Sorry for the mess. Hopefully this comment clears it up, otherwise just ask. :)

@swissspidy
Copy link
Owner

@NekoJonez
Copy link
Author

https://translate.wordpress.org/projects/wp-plugins/preferred-languages/stable/nl-be/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=5117659&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc

It is translated, yet it refuses to show up translated on my websites... How would I best troubleshoot this? Remove the po/mo file and let it redownload?

@swissspidy
Copy link
Owner

Back at the computer now and I think I can now reproduce this issue. When Preferred Languages is active, the description on wp-admin/plugins.php is indeed not translated, even though a translation exists.

So yeah, looks like a bug after all!

I'll look into it!

@swissspidy
Copy link
Owner

Turns out this is a bug in the translation file generation on WordPress.org, not this plugin.

This happens because the plugin description is identical to a string used on the JS side, so WP.org ends up not adding the string to the .mo file.

I just opened https://meta.trac.wordpress.org/ticket/7376 and wp-cli/i18n-command#376 to track this.

In the meantime I could work around this by slightly altering the plugin description.

@NekoJonez
Copy link
Author

Interesting, I am curious to see the solution. :)
Happy to help

swissspidy added a commit that referenced this issue Dec 18, 2023
@swissspidy
Copy link
Owner

In 2aeb0d7 I changed the plugin description, so with the next release this will be resolved (once it is translated by the community).

There's also wp-cli/i18n-command#377 to potentially fix this for all plugins on dotorg with the same issue (probably not many)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants