projects using maker-bundle are enforced to switch from friendsofphp/php-cs-fixer to php-cs-fixer/shim #1653
Comments
kbond
added a commit
that referenced
this issue
Jan 15, 2025
…al PHAR) (kbond) This PR was merged into the 1.x-dev branch. Discussion ---------- Revert #1575 (Use a PHP-CS-Fixer shim rather than an external PHAR) This reverts #1575. This PR has caused a lot of trouble as it made php-cs-fixer a required dep which installs a recipe. See #1644, #1653, #1651, #1648. We can't have php-cs-fixer (or the shim) as a required dependency. I think we need to have this bundle only use php-cs-fixer if available/configured (or drop it entirely). I'm not sure why it is used at all - feels like a lot of added complexity... Commits ------- 41744d7 Revert "feature #1575 [make:*] Use a PHP-CS-Fixer shim rather than an external PHAR"
|
I've reverted #1575 and released v1.62.1. It was causing a lot of problems. I think we need to rethink the php-cs-fixer integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@jrushlow @theofidry
The composer.json of
php-cs-fixer/shimcontains a replace section which replacesfriendsofphp/php-cs-fixerbyphp-cs-fixer/shimin all projects which are using the maker-bundle.I suspect that this invasive effect was not intended. I therefore propose to revert #1575 quickly and make a new release. Then you can work on a better solution later.
The text was updated successfully, but these errors were encountered: