-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebLink] Confusing explanation of asset preloading #20554
Comments
What we need to clarify here is:
|
@javiereguiluz i’ve experience this as well recently on a project when reading doc and blog and code To me there is room for doc update indeed, perhaps as well with some graph? |
Let's ping our friend @dunglas to see if he can explain this to us and then we can update the docs based on those comments. Thanks. |
Can already answer some of your comments here: Regarding the contradiction, we may use a better example in the second one, for instance preloading a webfont that will be used in the page but declared in a CSS file. First comment can be removed i think. It was certainely written on good intention: avoiding someone thinking just using the preload tag will load it's CSS. But in the end i agree it may create more doubts than help. We can totally write all the answers for the questions you asked, but I also think we should be transparent on the expected impacts, and maybe list the other things to do to achieve better performance (as i'm afraid not everyone is already aware of the first things to check... and would not want people to believe they have to handle this in priority when assets size, lazy loading, cache, should (maybe?) be done before any header optimization) |
In my opinion, this page is confusing: https://symfony.com/doc/current/web_link.html
There are repeated explanations about asset preloading and they seem to contradict each other:
The text was updated successfully, but these errors were encountered: