-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charging thresholds don't persist through an EC reset #128
Comments
Could be done with #63. |
Using a minimized implementation of #256 for just battery thresholds:
Could increase it to reserve some space.
EC should do bounds checking on the values when read even if the magic byte is valid and fall back to the defaults if it fails. There's probably multiple things that set thresholds on boot now since they aren't persistent. EC should probably only write thresholds to flash if they've been changed to minimize the amount of writing to EC flash. It would mean having the distinction of "apply" (change is only in RAM) vs "commit" (change is written to flash). |
Basic implementation done in #498. |
If I set custom charging thresholds on oryp6, they reset when shutting the machine down and disconnecting the charger. I discovered this while testing pop-os/system76-power#197.
The text was updated successfully, but these errors were encountered: