Error in fix-outline.py causes webfont icons build to fail

[ethancrawford]

Description

After running the steps described below in Steps to reproduce, the console eventually spits out multiple errors during the build process every time it attempts to run /packages/icons-webfont/.build/fix-outline.py - Eg:

pnpm build:webfont

> [email protected] build:webfont /home/ethan/repos/tabler-icons
> pnpm --filter @tabler/icons-webfont build


> @tabler/[email protected] build /home/ethan/repos/tabler-icons/packages/icons-webfont
> pnpm run copy && pnpm run build:prepare && pnpm run build:outline && pnpm run build:webfont && pnpm run build:css


> @tabler/[email protected] copy /home/ethan/repos/tabler-icons/packages/icons-webfont
> pnpm run copy:license


> @tabler/[email protected] copy:license /home/ethan/repos/tabler-icons/packages/icons-webfont
> cp ../../LICENSE ./LICENSE


> @tabler/[email protected] build:prepare /home/ethan/repos/tabler-icons/packages/icons-webfont
> mkdir -p icons-outlined dist && rm -fdr dist/*


> @tabler/[email protected] build:outline /home/ethan/repos/tabler-icons/packages/icons-webfont
> node .build/build-outline.mjs

outline a-b-2
Stroke for: a-b-2 f25f
Copyright (c) 2000-2024. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20201107
 Based on sources from 2024-06-24 13:55 UTC-ML-D-GDK3.
PythonUI_Init()
copyUIMethodsToBaseTable()
Traceback (most recent call last):
  File "/home/ethan/repos/tabler-icons/packages/icons-webfont/.build/fix-outline.py", line 4, in <module>
    file = sys.argv[1]
NameError: name 'sys' is not defined
Error: Command failed: fontforge -lang=py -script .build/fix-outline.py icons-outlined/outline/uF25F-a-b-2.svg

Package

• @tabler/icons
• @tabler/icons-eps
• @tabler/icons-pdf
• @tabler/icons-png
• @tabler/icons-webfont
• @tabler/icons-sprite
• @tabler/icons-preact
• @tabler/icons-react
• @tabler/icons-react-native
• @tabler/icons-solid
• @tabler/icons-svelte
• @tabler/icons-vue
• Figma plugin
• source/main
• other/not relevant

Version

3.20.0

Browser

• Chrome/Chromium
• Firefox
• Safari
• Edge
• iOS Safari
• Opera
• Other/not relevant

Operating system

• Windows
• Linux
• macOS
• ChromeOS
• iOS
• Android
• Other/not relevant

Steps to reproduce

• Clone the tabler-icons repository & cd into the project folder
• Install fontforge via sudo apt-get install fontforge (Installed version was fontforge 20201107)
• Update"packageManager" reference in /package.json to "[email protected]"
• Run the following commands on the command line in the project folder

corepack enable pnpm
pnpm install
pnpm build:webfont

Checklist

• I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)

[Greatness7]

See #1069 from 7 months ago.

[ethancrawford]

Ha. Oh well, I thought I'd done a reasonable search through the past issues 😂🤷